[Fix][JDBC] Fix starrocks jdbc dialect catalog conflict with starrocks connector #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Sep 4, 2024
liunaijie
force-pushed
the
hotfix/sr_jdbc_dialect
branch
from
94c3199 to
08d2e82
Compare
Hisoka-X
changed the title
Hisoka-X
reviewed
Sep 12, 2024
| value = {}, | ||
| type = {EngineType.FLINK, EngineType.SPARK}, | ||
| disabledReason = "only Zeta Engine can get this log") | ||
| void checkResult(String executeKey, TestContainer container, Container.ExecResult execResult) { |
liunaijie
force-pushed
the
hotfix/sr_jdbc_dialect
branch
from
f2c6054 to
366b9a4
Compare
liunaijie
force-pushed
the
hotfix/sr_jdbc_dialect
branch
from
a5d4931 to
45e5ba4
Compare
liunaijie
commented
Sep 13, 2024
| @@ -112,7 +112,7 @@ public abstract class AbstractJdbcIT extends TestSuiteBase implements TestResour | |||
|
|
|||
| abstract JdbcCase getJdbcCase(); | |||
|
|
|||
| abstract void compareResult(String executeKey) throws SQLException, IOException; | |||
| void checkResult(String executeKey, TestContainer container, Container.ExecResult execResult) {} | |||
There was a problem hiding this comment.
add more parameter to help check log.
and delete the abstract keyword, the implement class only need implement it when necessary.
liunaijie
commented
Sep 13, 2024
| if (container.identifier().equals(TestContainerId.SEATUNNEL)) { | ||
| Assertions.assertTrue( | ||
| execResult.getStdout().contains("Loading catalog tables for catalog")); | ||
| } |
There was a problem hiding this comment.
i run some test, find the stdout and container log is different on different engine and version.
so here only check seatunnel engine's log.
There was a problem hiding this comment.
when has this log Loading catalog tables for catalog means it was load table from MySQLCatalog. rather than
use jdbc.
related log location:
https://github.com/apache/seatunnel/blob/dev/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java#L77
hailin0
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #7551
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.